Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Improve replica selection policy performance #35859

Closed
1 task done
weiliu1031 opened this issue Aug 30, 2024 · 2 comments
Closed
1 task done

[Enhancement]: Improve replica selection policy performance #35859

weiliu1031 opened this issue Aug 30, 2024 · 2 comments
Assignees
@weiliu1031
Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days

Comments

@weiliu1031
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

when replica increase, replica selection policy's cost shouldn't increase, we should improve it's performance

Why is this needed?

No response

Anything else?

No response
@weiliu1031 weiliu1031 added the kind/enhancement Issues or changes related to enhancement label Aug 30, 2024
@weiliu1031
Copy link
Contributor Author

/assign

This was referenced Aug 30, 2024
Merged
Merged
Closed
Closed
@weiliu1031 weiliu1031 mentioned this issue Sep 11, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Sep 13, 2024
@weiliu1031
enhance: Enable dynamic update replica selection policy (#35860)
bd658a6 
issue: #35859

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Sep 13, 2024
@weiliu1031
enhance: Enable dynamic update replica selection policy (#35824)
5cd8606 
issue: #35859
pr: #35860

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
sre-ci-robot pushed a commit that referenced this issue Sep 20, 2024
@weiliu1031
enhance: Optimize workload based replica selection policy (#36181)
3b10085 
issue: #35859

This PR introduce two new param: toleranceFactor and checkRequestNum,
after every checkRequestNum request has been assigned, try to compute
querynode's workload score.

if the diff is less than the toleranceFactor, replica selection policy
will fallback to round_robin, which reduce the average cost to about
500ns.

if the diff is larger than the toleranceFactor, replica selection policy
will compute querynode's score to select the target node with smallest
score in every assigment.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
weiliu1031 added a commit to weiliu1031/milvus that referenced this issue Sep 20, 2024
@weiliu1031
enhance: Optimize workload based replica selection policy (milvus-io#…
f555fcb 
…36181)

issue: milvus-io#35859

This PR introduce two new param: toleranceFactor and checkRequestNum,
after every checkRequestNum request has been assigned, try to compute
querynode's workload score.

if the diff is less than the toleranceFactor, replica selection policy
will fallback to round_robin, which reduce the average cost to about
500ns.

if the diff is larger than the toleranceFactor, replica selection policy
will compute querynode's score to select the target node with smallest
score in every assigment.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 mentioned this issue Sep 20, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Sep 26, 2024
@weiliu1031
enhance: Optimize workload based replica selection policy (#36181) (#…
ad5d24b 
…36384)

issue: #35859
pr: #36181

This PR introduce two new param: toleranceFactor and checkRequestNum,
after every checkRequestNum request has been assigned, try to compute
querynode's workload score.

if the diff is less than the toleranceFactor, replica selection policy
will fallback to round_robin, which reduce the average cost to about
500ns.

if the diff is larger than the toleranceFactor, replica selection policy
will compute querynode's score to select the target node with smallest
score in every assigment.

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@stale Stale
Copy link

stale bot commented Sep 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weiliu1031 weiliu1031

Labels
kind/enhancement Issues or changes related to enhancement stale indicates no udpates for 30 days
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@weiliu1031