Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #2199 #2355

Merged
merged 1 commit into from
May 15, 2020
Merged

Issue #2199 #2355

merged 1 commit into from
May 15, 2020

Conversation

PahudPlus
Copy link
Contributor

Signed-off-by: PahudPlus haimeng.cai@zilliz.com

What type of PR is this?

api-change / bug / design / documentation / feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Additional documentation (e.g. design docs, usage docs, etc.):

Signed-off-by: PahudPlus <haimeng.cai@zilliz.com>
@PahudPlus PahudPlus requested a review from JinHai-CN as a code owner May 15, 2020 08:24
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #2355 into 0.9.0 will decrease coverage by 0.51%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.9.0    #2355      +/-   ##
==========================================
- Coverage   89.47%   88.96%   -0.52%     
==========================================
  Files         423      423              
  Lines       26099    26051      -48     
==========================================
- Hits        23353    23177     -176     
- Misses       2746     2874     +128     
Impacted Files Coverage Δ
...src/server/delivery/request/SearchCombineRequest.h 0.00% <0.00%> (-100.00%) ⬇️
core/src/server/delivery/request/SearchRequest.h 16.66% <0.00%> (-83.34%) ⬇️
...src/server/delivery/strategy/SearchReqStrategy.cpp 0.00% <0.00%> (-71.43%) ⬇️
...c/server/delivery/request/SearchCombineRequest.cpp 0.00% <0.00%> (-69.68%) ⬇️
core/src/server/delivery/RequestQueue.cpp 72.22% <0.00%> (-22.23%) ⬇️
.../src/server/delivery/request/SearchByIDRequest.cpp 71.05% <0.00%> (-1.45%) ⬇️
core/src/server/delivery/request/SearchRequest.cpp 67.69% <0.00%> (-0.97%) ⬇️
...nowhere/knowhere/index/vector_index/IndexAnnoy.cpp 75.60% <0.00%> (-0.30%) ⬇️
.../src/server/web_impl/handler/WebRequestHandler.cpp 76.49% <0.00%> (-0.14%) ⬇️
core/src/scheduler/task/BuildIndexTask.cpp 92.03% <0.00%> (-0.07%) ⬇️
... and 19 more

@JinHai-CN JinHai-CN merged commit 7d7a67a into milvus-io:0.9.0 May 15, 2020
JinHai-CN pushed a commit that referenced this pull request May 15, 2020
Signed-off-by: PahudPlus <haimeng.cai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants