Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.2.x] Fix Int8~Int32 empty result set type #23851

Merged
merged 1 commit into from
May 4, 2023

Conversation

congqixia
Copy link
Contributor

See also #23850
/kind bug

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/bug Issues or changes related a bug approved size/S Denotes a PR that changes 10-29 lines. labels May 4, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Merging #23851 (d6b0e56) into 2.2.0 (3b6ea03) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #23851      +/-   ##
==========================================
+ Coverage   80.66%   80.69%   +0.02%     
==========================================
  Files         713      713              
  Lines      101736   101749      +13     
==========================================
+ Hits        82063    82103      +40     
+ Misses      16462    16440      -22     
+ Partials     3211     3206       -5     
Impacted Files Coverage Δ
internal/util/typeutil/gen_empty_field_data.go 97.95% <100.00%> (+0.94%) ⬆️

... and 21 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 4, 2023
Copy link
Member

@yah01 yah01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2fae8b8 into milvus-io:2.2.0 May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants