Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Int8~Int32 empty result set type #23852

Merged
merged 1 commit into from
May 6, 2023

Conversation

congqixia
Copy link
Contributor

See also #23850
/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label May 4, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels May 4, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 4, 2023
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

@congqixia ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #23852 (3c58ef1) into master (e172f3e) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #23852      +/-   ##
==========================================
+ Coverage   79.58%   79.82%   +0.23%     
==========================================
  Files         745      744       -1     
  Lines       99680    97590    -2090     
==========================================
- Hits        79333    77899    -1434     
+ Misses      17205    16536     -669     
- Partials     3142     3155      +13     
Impacted Files Coverage Δ
pkg/util/typeutil/gen_empty_field_data.go 100.00% <100.00%> (ø)

... and 188 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 6, 2023
@jiaoew1991
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 2cacda0 into milvus-io:master May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants