Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the length of JSON #24035

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

yah01
Copy link
Member

@yah01 yah01 commented May 11, 2023

/kind improvement
related #23389

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label May 11, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 11, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 11, 2023
@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels May 11, 2023
@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #24035 (69f1543) into master (ab95754) will increase coverage by 0.00%.
The diff coverage is 77.27%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #24035    +/-   ##
========================================
  Coverage   82.08%   82.08%            
========================================
  Files         754      754            
  Lines       98430    98539   +109     
========================================
+ Hits        80794    80885    +91     
- Misses      14646    14662    +16     
- Partials     2990     2992     +2     
Impacted Files Coverage Δ
internal/proxy/validate_util.go 90.34% <66.66%> (-2.79%) ⬇️
pkg/util/paramtable/component_param.go 97.91% <100.00%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

Signed-off-by: yah01 <yang.cen@zilliz.com>
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiaoew1991 jiaoew1991 added ci-passed manual-pass manually set pass before ci-passed labeled labels May 12, 2023
@sre-ci-robot sre-ci-robot merged commit 7d0c47d into milvus-io:master May 12, 2023
yah01 added a commit to yah01/milvus that referenced this pull request May 23, 2023
Signed-off-by: yah01 <yang.cen@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request May 23, 2023
Signed-off-by: yah01 <yang.cen@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants