Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the segcore payload reader can't read JSON data #24212

Merged
merged 1 commit into from
May 20, 2023
Merged

Fix the segcore payload reader can't read JSON data #24212

merged 1 commit into from
May 20, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented May 18, 2023

/kind bug
related #23389

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label May 18, 2023
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label May 18, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 18, 2023
@codecov
Copy link

codecov bot commented May 18, 2023 •
edited
Loading

Codecov Report

Merging #24212 (3dd09ab) into 2.2.0 (fab0bff) will increase coverage by 0.04%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24212      +/-   ##
==========================================
+ Coverage   80.71%   80.76%   +0.04%     
==========================================
  Files         747      747              
  Lines      105659   105737      +78     
==========================================
+ Hits        85284    85395     +111     
+ Misses      17070    17023      -47     
- Partials     3305     3319      +14
Impacted Files Coverage Δ
internal/core/src/storage/FieldDataInterface.h 89.47% <ø> (ø)
internal/core/src/storage/parquet_c.cpp 73.78% <ø> (+1.94%) ⬆️
internal/util/typeutil/schema.go 72.48% <54.54%> (+3.55%) ⬆️
internal/core/src/storage/FieldData.cpp 93.65% <100.00%> (+0.79%) ⬆️
internal/datanode/compactor.go 75.98% <100.00%> (+0.44%) ⬆️

... and 33 files with indirect coverage changes

@yah01 yah01 force-pushed the fix-json-load branch 2 times, most recently from af632b1 to c2ff25f Compare May 18, 2023 06:58
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels May 18, 2023
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 18, 2023
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 18, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented May 19, 2023

rerun ut

@yah01
Copy link
Member Author

yah01 commented May 19, 2023

related #24219

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented May 19, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented May 19, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 20, 2023

@yah01 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented May 20, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label May 20, 2023
@yah01
Fix the segcore payload reader can't read JSON data
3dd09ab 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
@mergify mergify bot added ci-passed and removed ci-passed labels May 20, 2023
congqixia
congqixia approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1eb804f into milvus-io:2.2.0 May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@congqixia congqixia

Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yah01 @sre-ci-robot @congqixia