Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Support dynamic field for bulkinsert #24304

Merged
merged 1 commit into from
May 23, 2023

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented May 22, 2023

@yhmo yhmo requested a review from congqixia May 22, 2023 10:57
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 22, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 22, 2023
@mergify
Copy link
Contributor

mergify bot commented May 22, 2023

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented May 23, 2023

/run-cpu-e2e

@yhmo
Copy link
Contributor Author

yhmo commented May 23, 2023

rerun ut

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Merging #24304 (ab17614) into master (d16e18f) will increase coverage by 0.49%.
The diff coverage is 93.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24304      +/-   ##
==========================================
+ Coverage   81.85%   82.34%   +0.49%     
==========================================
  Files         769      758      -11     
  Lines      101869    99498    -2371     
==========================================
- Hits        83382    81930    -1452     
+ Misses      15451    14574     -877     
+ Partials     3036     2994      -42     
Impacted Files Coverage Δ
internal/util/importutil/numpy_parser.go 91.77% <14.28%> (-0.86%) ⬇️
internal/util/importutil/import_util.go 96.00% <94.64%> (+0.50%) ⬆️
internal/distributed/datacoord/client/client.go 94.15% <97.95%> (+20.42%) ⬆️
internal/util/importutil/json_parser.go 86.56% <100.00%> (+3.33%) ⬆️

... and 174 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 23, 2023
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 97cd040 into milvus-io:master May 23, 2023
@yhmo yhmo deleted the cc branch June 30, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants