Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single quotes with string (#24386) #24406

Merged
merged 1 commit into from
May 25, 2023

Conversation

xiaocai2333
Copy link
Contributor

issue: #24232

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label May 25, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 25, 2023
Signed-off-by: cai.zhang <cai.zhang@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented May 25, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #24406 (cdd07a2) into 2.2.0 (ef1a671) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head cdd07a2 differs from pull request most recent head 094437a. Consider uploading reports for the commit 094437a to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24406      +/-   ##
==========================================
- Coverage   80.84%   80.83%   -0.01%     
==========================================
  Files         759      759              
  Lines      106198   106204       +6     
==========================================
- Hits        85851    85850       -1     
- Misses      17031    17039       +8     
+ Partials     3316     3315       -1     
Impacted Files Coverage Δ
internal/parser/planparserv2/parser_visitor.go 85.73% <100.00%> (+0.76%) ⬆️
internal/parser/planparserv2/plan_parser_v2.go 90.10% <100.00%> (+0.45%) ⬆️

... and 14 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 25, 2023
@czs007
Copy link
Collaborator

czs007 commented May 25, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d951f8a into milvus-io:2.2.0 May 25, 2023
@xiaocai2333 xiaocai2333 deleted the support_single_quotes-2 branch June 7, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants