Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] Fix a bug of bulkinsert dynamic schema (#24405) #24527

Merged
merged 1 commit into from
May 31, 2023
Merged

[cherry-pick] Fix a bug of bulkinsert dynamic schema (#24405) #24527

merged 1 commit into from
May 31, 2023

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented May 30, 2023

@yhmo
Fix a bug of bulkinsert dynamic schema (milvus-io#24405)
1a0ca8e 
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 30, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #24527 (1a0ca8e) into master (b09e7ae) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24527      +/-   ##
==========================================
- Coverage   82.60%   82.57%   -0.03%     
==========================================
  Files         766      766              
  Lines      100821   100822       +1     
==========================================
- Hits        83283    83255      -28     
- Misses      14524    14546      +22     
- Partials     3014     3021       +7
Impacted Files Coverage Δ
internal/util/importutil/import_wrapper.go 86.64% <100.00%> (+0.03%) ⬆️

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 30, 2023
congqixia
congqixia approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3cb7599 into milvus-io:master May 31, 2023
@yhmo yhmo deleted the mm branch June 8, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@sunby sunby Awaiting requested review from sunby

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhmo @sre-ci-robot @congqixia