Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug of bulkinsert for dynamic field #24568

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented May 31, 2023

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label May 31, 2023
@mergify mergify bot added the dco-passed DCO check passed. label May 31, 2023
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #24568 (1977d67) into 2.2.0 (3fb9334) will decrease coverage by 0.02%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##            2.2.0   #24568      +/-   ##
==========================================
- Coverage   80.90%   80.88%   -0.02%     
==========================================
  Files         759      759              
  Lines      106450   106454       +4     
==========================================
- Hits        86125    86110      -15     
- Misses      17019    17034      +15     
- Partials     3306     3310       +4     
Impacted Files Coverage Δ
internal/util/importutil/import_util.go 95.15% <84.00%> (-0.86%) ⬇️
internal/util/importutil/numpy_parser.go 92.82% <100.00%> (+0.97%) ⬆️

... and 12 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 31, 2023
@czs007
Copy link
Collaborator

czs007 commented May 31, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f11ad94 into milvus-io:2.2.0 May 31, 2023
@yhmo yhmo deleted the 222 branch July 24, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants