Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick] Fix potential crash bug of bulkinsert #24763

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented Jun 8, 2023

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 8, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Jun 8, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2023

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #24763 (b6b746b) into master (dacf8b3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24763      +/-   ##
==========================================
+ Coverage   82.35%   82.40%   +0.05%     
==========================================
  Files         777      777              
  Lines      102339   102342       +3     
==========================================
+ Hits        84279    84337      +58     
+ Misses      15020    14985      -35     
+ Partials     3040     3020      -20     
Impacted Files Coverage Δ
internal/datanode/services.go 83.17% <100.00%> (+0.86%) ⬆️

... and 22 files with indirect coverage changes

@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@yhmo
Copy link
Contributor Author

yhmo commented Jun 9, 2023

rerun ui

@yhmo
Copy link
Contributor Author

yhmo commented Jun 9, 2023

rerun ut

1 similar comment
@yhmo
Copy link
Contributor Author

yhmo commented Jun 9, 2023

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented Jun 9, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Jun 9, 2023

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

@yhmo E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yhmo
Copy link
Contributor Author

yhmo commented Jun 12, 2023

/run-cpu-e2e

@yhmo
Copy link
Contributor Author

yhmo commented Jun 12, 2023

/rerun ut

@yhmo
Copy link
Contributor Author

yhmo commented Jun 12, 2023

rerun ut

@mergify mergify bot added the ci-passed label Jun 12, 2023
@jiaoew1991
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5c3b744 into milvus-io:master Jun 13, 2023
zhagnlu pushed a commit to zhagnlu/milvus that referenced this pull request Jun 13, 2023
Signed-off-by: yhmo <yihua.mo@zilliz.com>
@yhmo yhmo deleted the mm branch June 30, 2023 08:13
zhuwenxing pushed a commit to mmga-lab/milvus that referenced this pull request Jul 25, 2023
Signed-off-by: yhmo <yihua.mo@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants