Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server id validation interceptor #26395

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

bigsheeper
Copy link
Contributor

issue: #26219

/kind bug

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Aug 16, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 16, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #26395 (be27b34) into master (3c62acd) will increase coverage by 0.00%.
Report is 5 commits behind head on master.
The diff coverage is 61.78%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26395   +/-   ##
=======================================
  Coverage   79.82%   79.83%           
=======================================
  Files         819      820    +1     
  Lines      112142   112221   +79     
=======================================
+ Hits        89521    89594   +73     
- Misses      19409    19420   +11     
+ Partials     3212     3207    -5     
Files Changed Coverage Δ
internal/datacoord/session.go 75.67% <0.00%> (ø)
pkg/util/merr/errors.go 60.86% <ø> (ø)
pkg/util/merr/utils.go 68.86% <0.00%> (-1.11%) ⬇️
pkg/util/interceptor/server_id_interceptor.go 28.26% <28.26%> (ø)
internal/util/grpcclient/client.go 78.68% <58.82%> (-0.92%) ⬇️
internal/datacoord/indexnode_manager.go 89.88% <100.00%> (ø)
internal/datacoord/server.go 61.06% <100.00%> (ø)
internal/datacoord/session_manager.go 86.72% <100.00%> (-0.48%) ⬇️
internal/distributed/datacoord/service.go 92.51% <100.00%> (+0.06%) ⬆️
internal/distributed/datanode/client/client.go 94.57% <100.00%> (+0.04%) ⬆️
... and 17 more

... and 7 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/XXL Denotes a PR that changes 1000+ lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Aug 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

@bigsheeper ut workflow job failed, comment rerun ut can trigger the job again.

@weiliu1031
Copy link
Contributor

/lgtm

@weiliu1031
Copy link
Contributor

/cc @congqixia

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Aug 17, 2023

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Collaborator

czs007 commented Aug 17, 2023

/lgtm

@sre-ci-robot sre-ci-robot merged commit 63b86b3 into milvus-io:master Aug 17, 2023
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Aug 18, 2023
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Aug 18, 2023
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants