Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed to load collection with more than 128 partitions #26763

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix failed to load collection with more than 128 partitions #26763

merged 1 commit into from
Sep 1, 2023

Conversation

yah01
Copy link
Member

@yah01 yah01 commented Aug 31, 2023

/kind bug
fix #26762

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Aug 31, 2023
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 31, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Aug 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

yanliang567 pushed a commit to yanliang567/milvus that referenced this pull request Aug 31, 2023
@MrPresent-Han
modify default value for sync max parallel to mitigate oom on dn(milv…
3421956 
…us-io#26763) (milvus-io#26231)

Signed-off-by: MrPresent-Han <chun.han@zilliz.com>
@yah01
Copy link
Member Author

yah01 commented Aug 31, 2023

/run-cpu-e2e

@yah01 yah01 force-pushed the fix-many-partitions branch from 872181f to 2875934 Compare August 31, 2023 10:46
@codecov
Copy link

codecov bot commented Aug 31, 2023 •
edited
Loading

Codecov Report

Merging #26763 (db51d48) into master (8330c18) will decrease coverage by 0.02%.
Report is 20 commits behind head on master.
The diff coverage is 76.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26763      +/-   ##
==========================================
- Coverage   82.35%   82.34%   -0.02%     
==========================================
  Files         796      796              
  Lines      111131   111168      +37     
==========================================
+ Hits        91524    91537      +13     
- Misses      16486    16504      +18     
- Partials     3121     3127       +6
Files Changed Coverage Δ
...rnal/querycoordv2/observers/collection_observer.go 89.33% <0.00%> (+0.52%) ⬆️
internal/metastore/kv/querycoord/kv_catalog.go 65.24% <54.54%> (-2.43%) ⬇️
internal/querycoordv2/job/undo.go 72.22% <76.19%> (+9.06%) ⬆️
internal/querycoordv2/job/job_load.go 89.78% <100.00%> (+0.07%) ⬆️
internal/querycoordv2/job/job_release.go 79.24% <100.00%> (ø)
internal/querycoordv2/meta/collection_manager.go 87.93% <100.00%> (+0.72%) ⬆️

... and 46 files with indirect coverage changes

@yah01
Copy link
Member Author

yah01 commented Sep 1, 2023

related #26748

@yah01 yah01 force-pushed the fix-many-partitions branch from 2875934 to 23a1e9a Compare September 1, 2023 03:30
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yah01
Copy link
Member Author

yah01 commented Sep 1, 2023

/run-cpu-e2e

@yah01
Fix failed to load collection with more than 128 partitions
db51d48 
Signed-off-by: yah01 <yah2er0ne@outlook.com>
@yah01 yah01 force-pushed the fix-many-partitions branch from 23a1e9a to db51d48 Compare September 1, 2023 10:42
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@yah01 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan, yah01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Sep 1, 2023
@xiaofan-luan
Copy link
Collaborator

/lgtm

@mergify mergify bot removed the ci-passed label Sep 1, 2023
@xiaofan-luan xiaofan-luan added ci-passed manual-pass manually set pass before ci-passed labeled labels Sep 1, 2023
@sre-ci-robot sre-ci-robot merged commit 941a383 into milvus-io:master Sep 1, 2023
@yah01 yah01 mentioned this pull request Sep 12, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofan-luan xiaofan-luan xiaofan-luan left review comments

@sunby sunby Awaiting requested review from sunby

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: unable to load collection with more than 128 partitions
3 participants
@yah01 @xiaofan-luan @sre-ci-robot