Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance FlushAll/GetFlushAllState API #26802

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Sep 1, 2023

issue: #26777

@sre-ci-robot sre-ci-robot added do-not-merge/work-in-progress Don't merge even CI passed. area/dependency Pull requests that update a dependency file labels Sep 1, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 1, 2023
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Sep 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@wayblink Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify
Copy link
Contributor

mergify bot commented Sep 1, 2023

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Sep 1, 2023
@wayblink wayblink changed the title [WIP]:enhance flushall Enhance FlushAll/GetFlushAllState API Sep 1, 2023
@sre-ci-robot sre-ci-robot removed the do-not-merge/work-in-progress Don't merge even CI passed. label Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #26802 (5e37dd0) into master (73f4347) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26802      +/-   ##
==========================================
- Coverage   82.30%   82.29%   -0.01%     
==========================================
  Files         796      796              
  Lines      110538   110558      +20     
==========================================
+ Hits        90973    90985      +12     
- Misses      16437    16440       +3     
- Partials     3128     3133       +5     
Files Changed Coverage Δ
internal/datacoord/services.go 85.20% <100.00%> (+0.09%) ⬆️
internal/proxy/impl.go 85.70% <100.00%> (+0.03%) ⬆️

... and 16 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 3, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 5, 2023

@wayblink ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@bigsheeper
Copy link
Contributor

/lgtm

@czs007 czs007 added this to the 2.3.1 milestone Sep 6, 2023
@czs007
Copy link
Collaborator

czs007 commented Sep 6, 2023

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d7b6f3a into milvus-io:master Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants