Fix datanode panic due to concurrent compaction and delete processing #27167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuanYang-cn
suggested changes
Sep 18, 2023
| @@ -678,7 +678,7 @@ func (c *ChannelMeta) getCollectionSchema(collID UniqueID, ts Timestamp) (*schem | |||
| return c.collSchema, nil | |||
| } | |||
|
|
|||
| func (c *ChannelMeta) mergeFlushedSegments(ctx context.Context, seg *Segment, planID UniqueID, compactedFrom []UniqueID) error { | |||
| func (c *ChannelMeta) mergeFlushedSegments(ctx context.Context, seg *Segment, planID UniqueID, compactedFrom []UniqueID) { | |||
There was a problem hiding this comment.
ctx can be safely removed here since we don't check it anymore
There was a problem hiding this comment.
ctx can be used for tracing
XuanYang-cn
suggested changes
Sep 18, 2023
XuanYang-cn
suggested changes
Sep 18, 2023
Signed-off-by: xiaofan-luan <xiaofan.luan@zilliz.com> Co-authored-by: bigsheeper <yihao.dai@zilliz.com>
bigsheeper
force-pushed
the
2309-FixPanicDueToCompaction-master
branch
from
207a3de to
80b0fd7
Compare
Codecov Report
@@ Coverage Diff @@
## master #27167 +/- ##
==========================================
- Coverage 82.51% 82.49% -0.03%
==========================================
Files 796 796
Lines 112550 112576 +26
==========================================
- Hits 92873 92866 -7
- Misses 16472 16496 +24
- Partials 3205 3214 +9
|
|
LGTM |
xiaofan-luan
added
ci-passed
manual-pass
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #27145
the datanode processing delete while compaction happened so flush can not succeed.
For fixing:
see also: #27158