Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support multiple vector indexes in a collection #27700

Merged
merged 2 commits into from
Dec 29, 2023

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Oct 13, 2023

issue: #25639

/kind improvement
Signed-off-by: xige-16 xi.ge@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 13, 2023
@sre-ci-robot sre-ci-robot added area/internal-api size/XL Denotes a PR that changes 500-999 lines. labels Oct 13, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b251c3a) 80.82% compared to head (249a7f2) 80.84%.
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27700      +/-   ##
==========================================
+ Coverage   80.82%   80.84%   +0.01%     
==========================================
  Files         917      917              
  Lines      127051   126905     -146     
==========================================
- Hits       102689   102590      -99     
+ Misses      21033    20999      -34     
+ Partials     3329     3316      -13     
Files Coverage Δ
internal/datacoord/index_service.go 94.74% <100.00%> (-0.03%) ⬇️
internal/datacoord/util.go 99.27% <100.00%> (+0.01%) ⬆️
internal/datacoord/index_meta.go 98.41% <97.50%> (-0.35%) ⬇️

... and 22 files with indirect coverage changes

@czs007 czs007 added this to the 2.4.0 milestone Oct 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 18, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

internal/datacoord/util.go Outdated Show resolved Hide resolved
internal/datacoord/util.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Oct 19, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

@xige-16, please be sure the pr should only have one commit, check https://github.com/milvus-io/milvus/blob/master/CODE_REVIEW.md for more details.

@mergify mergify bot added the needs-rebase label Oct 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Oct 20, 2023

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

internal/proxy/util.go Outdated Show resolved Hide resolved
@xige-16
Copy link
Contributor Author

xige-16 commented Nov 1, 2023

rerun ut

Copy link
Contributor

mergify bot commented Nov 16, 2023

@xige-16

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • enhance: for improvements to existing functionality.
  • fix: for bug fixes.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, enhance, or fix.

Example:

feat: Enhance search functionality within the user interface

Please review and update your PR to comply with these guidelines.

Copy link

stale bot commented Dec 16, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Dec 16, 2023
@stale stale bot closed this Dec 23, 2023
@xige-16 xige-16 reopened this Dec 25, 2023
@stale stale bot removed the stale indicates no udpates for 30 days label Dec 25, 2023
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Dec 26, 2023
@xige-16 xige-16 changed the title Add fieldName param when drop and describe index feat: Support multiple vector indexes in a collection Dec 26, 2023
@mergify mergify bot added kind/feature Issues related to feature request from users and removed do-not-merge/invalid-pr-format labels Dec 26, 2023
Copy link
Contributor

mergify bot commented Dec 26, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Dec 27, 2023

@xige-16 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 27, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: xige-16 <xi.ge@zilliz.com>
Signed-off-by: xige-16 <xi.ge@zilliz.com>
Copy link
Contributor

mergify bot commented Dec 28, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xige-16
Copy link
Contributor Author

xige-16 commented Dec 28, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 28, 2023
@xiaocai2333
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Dec 29, 2023

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xige-16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0267391 into milvus-io:master Dec 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/internal-api ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants