Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load collection when all vector fields has index #27831

Closed
wants to merge 1 commit into from

Conversation

xige-16
Copy link
Contributor

@xige-16 xige-16 commented Oct 20, 2023

issue: #25639

/kind improvement
Signed-off-by: xige-16 xi.ge@zilliz.com

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Oct 20, 2023
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 20, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Oct 20, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 20, 2023

@xige-16 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #27831 (2790114) into master (babf4e3) will increase coverage by 0.03%.
Report is 68 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27831      +/-   ##
==========================================
+ Coverage   81.71%   81.74%   +0.03%     
==========================================
  Files         819      819              
  Lines      116062   116065       +3     
==========================================
+ Hits        94845    94883      +38     
+ Misses      18048    18021      -27     
+ Partials     3169     3161       -8     
Files Coverage Δ
internal/proxy/task.go 85.98% <100.00%> (+0.29%) ⬆️

... and 15 files with indirect coverage changes

Signed-off-by: xige-16 <xi.ge@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xige-16
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants