Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix bug for parse expression that include quotes #28418

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: Fix bug for parse expression that include quotes #28418

merged 1 commit into from
Nov 24, 2023

Conversation

xiaocai2333
Copy link
Contributor

master pr: #28416
issue: #28365
Fix bug for parsing error when a string enclosed in single quotes in an expression contains multiple double quotes.
such as:

expr = "tag == '\"blue\"'"

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 14, 2023
@xiaocai2333 xiaocai2333 changed the title Fix bug for parse expression that include quotes [pick] Fix bug for parse expression that include quotes Nov 14, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Nov 14, 2023
@xiaocai2333
Copy link
Contributor Author

rerun ut

@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023 •
edited
Loading

Codecov Report

Merging #28418 (3ba6d56) into 2.3 (1383680) will increase coverage by 0.00%.
Report is 12 commits behind head on 2.3.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.3   #28418   +/-   ##
=======================================
  Coverage   81.96%   81.96%           
=======================================
  Files         813      822    +9     
  Lines      117777   117802   +25     
=======================================
+ Hits        96534    96557   +23     
- Misses      18033    18036    +3     
+ Partials     3210     3209    -1
Files Coverage Δ
internal/parser/planparserv2/utils.go 88.73% <100.00%> (ø)
internal/datacoord/index_builder.go 91.98% <0.00%> (ø)

... and 156 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 16, 2023

@xiaocai2333

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • enhance: for improvements to existing functionality.
  • fix: for bug fixes.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, enhance, or fix.

Example:

feat: Enhance search functionality within the user interface

Please review and update your PR to comply with these guidelines.

@xiaocai2333 xiaocai2333 force-pushed the fix_bug_single_quote-2.3 branch from cce0b32 to ab0aac2 Compare November 17, 2023 01:37
@mergify mergify bot removed the ci-passed label Nov 17, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 17, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun ut

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333 xiaocai2333 changed the title [pick] Fix bug for parse expression that include quotes [pick] fix: Fix bug for parse expression that include quotes Nov 20, 2023
@xiaocai2333
Copy link
Contributor Author

rerun ut

@xiaocai2333 xiaocai2333 changed the title [pick] fix: Fix bug for parse expression that include quotes fix: Fix bug for parse expression that include quotes Nov 20, 2023
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels Nov 20, 2023
@xiaocai2333
Fix bug for parse expression that include quotes
3ba6d56 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the fix_bug_single_quote-2.3 branch from ab0aac2 to 3ba6d56 Compare November 20, 2023 12:02
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 23, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Nov 23, 2023
@mergify mergify bot removed the ci-passed label Nov 23, 2023
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@sre-ci-robot sre-ci-robot merged commit 968d6fd into milvus-io:2.3 Nov 24, 2023
13 of 14 checks passed
@xiaocai2333 xiaocai2333 deleted the fix_bug_single_quote-2.3 branch November 27, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby Awaiting requested review from sunby

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot