Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restful support new features #30485

Merged

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Feb 3, 2024

feat: restful support new features

  1. search with groupingField [Feature]: Add group by field features whens search #25324
  2. hybrid search [Feature]: Multiple Vector Search #25639

1. search with groupingField
2. hybrid search

Signed-off-by: PowderLi <min.li@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Feb 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users ci-passed labels Feb 3, 2024
Copy link

codecov bot commented Feb 3, 2024

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (36d3fd4) 80.29% compared to head (735a583) 80.29%.
Report is 27 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30485      +/-   ##
==========================================
- Coverage   80.29%   80.29%   -0.01%     
==========================================
  Files         966      966              
  Lines      136775   136845      +70     
==========================================
+ Hits       109822   109877      +55     
- Misses      23225    23241      +16     
+ Partials     3728     3727       -1     
Files Coverage Δ
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <100.00%> (ø)
...distributed/proxy/httpserver/timeout_middleware.go 79.09% <0.00%> (-0.73%) ⬇️
...nternal/distributed/proxy/httpserver/handler_v2.go 89.29% <81.70%> (-0.58%) ⬇️

... and 12 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Feb 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1b87bcd into milvus-io:master Feb 7, 2024
14 checks passed
PowderLi added a commit to PowderLi/milvus that referenced this pull request Mar 8, 2024
feat: restful support new features

1. search with groupingField milvus-io#25324
2. hybrid search milvus-io#25639

Signed-off-by: PowderLi <min.li@zilliz.com>
@PowderLi PowderLi deleted the master-restful-hybrid-search branch March 13, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants