Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] in segcore validate search sparse vector to make sure it is legal #33312

Merged
merged 1 commit into from
May 23, 2024

Conversation

zhengbuqian
Copy link
Collaborator

pr: #32856

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 May 23, 2024 06:39
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 23, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 23, 2024
@congqixia congqixia added this to the 2.4.3 milestone May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (ad4c197) to head (efdcebd).
Report is 8 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #33312      +/-   ##
==========================================
+ Coverage   82.14%   82.19%   +0.05%     
==========================================
  Files        1005      996       -9     
  Lines      128053   128278     +225     
==========================================
+ Hits       105184   105438     +254     
+ Misses      18913    18870      -43     
- Partials     3956     3970      +14     
Files Coverage Δ
internal/core/src/common/Utils.h 89.71% <100.00%> (+1.42%) ⬆️
internal/core/src/query/Plan.cpp 56.66% <100.00%> (+1.11%) ⬆️

... and 220 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 23, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ec33024 into milvus-io:2.4 May 23, 2024
15 checks passed
@zhengbuqian zhengbuqian deleted the sparse-search-check-2.4 branch May 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants