Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct get vector data size for bf16/fp16/binary vector #33377

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

chasingegg
Copy link
Contributor

related #22837

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 24, 2024
Copy link
Contributor

mergify bot commented May 24, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: chasingegg <chao.gao@zilliz.com>
Copy link
Contributor

mergify bot commented May 30, 2024

@chasingegg ut workflow job failed, comment rerun ut can trigger the job again.

@chasingegg
Copy link
Contributor Author

rerun ut

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.19%. Comparing base (7763718) to head (01432c1).
Report is 36 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33377      +/-   ##
==========================================
+ Coverage   82.12%   82.19%   +0.06%     
==========================================
  Files        1015     1006       -9     
  Lines      129767   129978     +211     
==========================================
+ Hits       106574   106829     +255     
+ Misses      19231    19164      -67     
- Partials     3962     3985      +23     
Files Coverage Δ
internal/core/src/common/Types.h 31.45% <ø> (+3.43%) ⬆️
internal/core/src/index/VectorDiskIndex.cpp 58.63% <100.00%> (+0.46%) ⬆️
internal/core/src/index/VectorMemIndex.cpp 39.30% <100.00%> (-0.19%) ⬇️

... and 231 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jun 5, 2024

/approve
/lgtm

@czs007 czs007 added this to the 2.4.5 milestone Jun 5, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 removed this from the 2.4.5 milestone Jun 5, 2024
@sre-ci-robot sre-ci-robot merged commit 545d472 into milvus-io:master Jun 5, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 5, 2024
…33488)

issue: #22837 
pr: #33377

Signed-off-by: chasingegg <chao.gao@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants