Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: disk index support binary vector #33631

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Jun 5, 2024

issue:#22837
related #33575

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Jun 5, 2024
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 5, 2024
Copy link
Contributor

mergify bot commented Jun 5, 2024

@cqy123456 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added the kind/enhancement Issues or changes related to enhancement label Jun 5, 2024
@cqy123456 cqy123456 changed the title enhance: [cherry-pick]disk index support binary vector enhance: disk index support binary vector Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.76%. Comparing base (8858fcb) to head (eaf5ee3).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33631      +/-   ##
==========================================
- Coverage   81.94%   81.76%   -0.18%     
==========================================
  Files        1015     1010       -5     
  Lines      130213   130926     +713     
==========================================
+ Hits       106701   107057     +356     
- Misses      19529    19843     +314     
- Partials     3983     4026      +43     
Files Coverage Δ
internal/core/src/common/Types.h 31.45% <ø> (+3.43%) ⬆️
internal/core/src/index/VectorDiskIndex.cpp 58.40% <ø> (+0.23%) ⬆️
internal/core/src/storage/DiskFileManagerImpl.cpp 63.46% <ø> (-1.05%) ⬇️
internal/core/src/index/IndexFactory.cpp 69.46% <0.00%> (+0.09%) ⬆️

... and 238 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jun 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 5, 2024
@sre-ci-robot sre-ci-robot merged commit 703fc73 into milvus-io:master Jun 5, 2024
13 of 14 checks passed
sre-ci-robot pushed a commit that referenced this pull request Jun 5, 2024
issue:#22837
related #33631

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue:milvus-io#22837
related milvus-io#33575

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled needs-dco DCO is missing in this pull request. size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants