-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [2.3] Print UseDefaultConsistency param in read requests (#33617) #33645
Conversation
…o#33617) `UseDefaultConsistency` param is crucial for debugging slow query problems. It could be confusing when guarantee timestamp is 1 while this param is not logged Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
@congqixia Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #33645 +/- ##
==========================================
- Coverage 83.09% 83.08% -0.01%
==========================================
Files 851 851
Lines 106727 106729 +2
==========================================
- Hits 88684 88676 -8
- Misses 14738 14746 +8
- Partials 3305 3307 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-pick from master
pr: #33617
UseDefaultConsistency
param is crucial for debugging slow query problems. It could be confusing when guarantee timestamp is 1 while this param is not logged