Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix binary vector data size #33750

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: fix binary vector data size #33750

merged 1 commit into from
Jun 18, 2024

Conversation

chasingegg
Copy link
Contributor

@chasingegg chasingegg commented Jun 11, 2024 •
edited
Loading

issue: #22837

  • fix byte size wrong for binary vectors
  • fix the expect/actual error msg

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jun 11, 2024
@chasingegg chasingegg mentioned this pull request Jun 11, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Jun 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (9d4535c) to head (2631b72).
Report is 47 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33750      +/-   ##
==========================================
+ Coverage   80.91%   81.03%   +0.11%     
==========================================
  Files        1058     1050       -8     
  Lines      135193   135596     +403     
==========================================
+ Hits       109397   109876     +479     
+ Misses      21613    21547      -66     
+ Partials     4183     4173      -10
Files Coverage Δ
internal/core/src/common/Types.h 34.23% <100.00%> (+6.21%) ⬆️
internal/core/src/index/IndexFactory.cpp 67.05% <100.00%> (+2.18%) ⬆️
internal/core/src/index/Utils.h 100.00% <100.00%> (ø)
internal/core/src/index/VectorMemIndex.cpp 39.23% <100.00%> (-0.15%) ⬇️
internal/proxy/validate_util.go 90.67% <100.00%> (ø)
internal/core/src/index/VectorDiskIndex.cpp 58.56% <75.00%> (+0.56%) ⬆️
internal/core/src/storage/DiskFileManagerImpl.cpp 60.49% <0.00%> (-1.13%) ⬇️

... and 231 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jun 11, 2024
sre-ci-robot pushed a commit that referenced this pull request Jun 12, 2024
@chasingegg
fix: [2.4] fix binary vector data size (#33751)
7ef2892 
issue #22837 
pr: #33750

Signed-off-by: chasingegg <chao.gao@zilliz.com>
@mergify mergify bot removed the ci-passed label Jun 12, 2024
@chasingegg
Copy link
Contributor Author

rerun ut

@chasingegg
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 12, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chasingegg
Copy link
Contributor Author

/run-cpu-e2e

@chasingegg
Copy link
Contributor Author

rerun ut

1 similar comment
@chasingegg
Copy link
Contributor Author

rerun ut

@chasingegg
Fix binary vector data size
2631b72 
Signed-off-by: chasingegg <chao.gao@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chasingegg
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chasingegg
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chasingegg
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 13, 2024

@chasingegg E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chasingegg
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jun 13, 2024
@czs007
Copy link
Contributor

czs007 commented Jun 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0d20303 into milvus-io:master Jun 18, 2024
15 checks passed
@chasingegg chasingegg deleted the fix-binary-dim branch June 18, 2024 13:40
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
@chasingegg @yellow-shine
fix: fix binary vector data size (milvus-io#33750)
4b97d68 
issue: milvus-io#22837

- fix byte size wrong for binary vectors
- fix the expect/actual error msg

Signed-off-by: chasingegg <chao.gao@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chasingegg @czs007 @sre-ci-robot