Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: check index with data type #33880

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Jun 14, 2024

issue: #22837
related: #33878

@sre-ci-robot sre-ci-robot added area/compilation size/M Denotes a PR that changes 30-99 lines. labels Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@cqy123456

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@cqy123456 cqy123456 changed the title enhence: check index with data type enhance: check index with data type Jun 14, 2024
Copy link
Contributor

mergify bot commented Jun 14, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jun 14, 2024
Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jun 14, 2024
)

issue: #22837
related: #33880

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (9b69601) to head (1d7645e).
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33880      +/-   ##
==========================================
+ Coverage   80.93%   81.02%   +0.08%     
==========================================
  Files        1058     1051       -7     
  Lines      135575   135775     +200     
==========================================
+ Hits       109732   110008     +276     
+ Misses      21654    21581      -73     
+ Partials     4189     4186       -3     
Files Coverage Δ
internal/proxy/task_index.go 80.10% <100.00%> (+0.13%) ⬆️
pkg/util/indexparamcheck/utils.go 100.00% <100.00%> (ø)
internal/core/src/segcore/check_vec_index_c.cpp 0.00% <0.00%> (ø)

... and 231 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jun 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Jun 19, 2024
@sre-ci-robot sre-ci-robot merged commit 298e50b into milvus-io:master Jun 19, 2024
14 of 15 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
issue: milvus-io#22837
related: milvus-io#33878

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants