Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [cherry-pick]remove CheckVecIndexWithDataTypeExist function in pkg #34104

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

cqy123456
Copy link
Contributor

issue: #22837
related pr: #34102

@cqy123456 cqy123456 changed the title enhance: remove CheckVecIndexWithDataTypeExist function in pkg enhance: [cherry-pick]remove CheckVecIndexWithDataTypeExist function in pkg Jun 24, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 24, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jun 24, 2024

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jun 25, 2024

@cqy123456 ut workflow job failed, comment rerun ut can trigger the job again.

@cqy123456
Copy link
Contributor Author

rerun ut

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.07%. Comparing base (65050b3) to head (6d5fdf2).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34104      +/-   ##
==========================================
+ Coverage   81.80%   82.07%   +0.27%     
==========================================
  Files        1016     1017       +1     
  Lines      130208   130208              
==========================================
+ Hits       106515   106874     +359     
+ Misses      19687    19330     -357     
+ Partials     4006     4004       -2     
Files Coverage Δ
internal/proxy/cgo_util.go 100.00% <100.00%> (ø)
internal/proxy/task_index.go 80.50% <100.00%> (ø)
pkg/util/indexparamcheck/utils.go 100.00% <ø> (ø)

... and 36 files with indirect coverage changes

@jaime0815
Copy link
Contributor

/lgtm

jaime0815 pushed a commit that referenced this pull request Jun 26, 2024
…move some cgo call (#34102)

issue: #22837
related pr: #34104

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
@jaime0815 jaime0815 merged commit 0bd93de into milvus-io:2.4 Jun 26, 2024
11 of 12 checks passed
@mergify mergify bot added the ci-passed label Jun 26, 2024
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
…move some cgo call (milvus-io#34102)

issue: milvus-io#22837
related pr: milvus-io#34104

Signed-off-by: cqy123456 <qianya.cheng@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants