Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine clustering_compaction_task retry mechanism #34194

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

wayblink
Copy link
Contributor

Signed-off-by: wayblink <anyang.wang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

@wayblink

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 18.42105% with 31 lines in your changes missing coverage. Please review.

Project coverage is 80.62%. Comparing base (f8bf690) to head (8e86de1).
Report is 20 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34194      +/-   ##
==========================================
- Coverage   84.63%   80.62%   -4.01%     
==========================================
  Files         808     1076     +268     
  Lines      113179   137216   +24037     
==========================================
+ Hits        95784   110635   +14851     
- Misses      13177    22425    +9248     
+ Partials     4218     4156      -62     
Files Coverage Δ
pkg/util/merr/errors.go 86.95% <ø> (ø)
pkg/util/merr/utils.go 81.79% <0.00%> (-1.37%) ⬇️
internal/datacoord/compaction_task_clustering.go 26.01% <25.92%> (-21.45%) ⬇️

... and 312 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Jun 26, 2024
@mergify mergify bot added ci-passed and removed ci-passed labels Jun 26, 2024
@czs007
Copy link
Collaborator

czs007 commented Jun 30, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 73ffc1b into milvus-io:master Jun 30, 2024
12 of 14 checks passed
yellow-shine pushed a commit to yellow-shine/milvus that referenced this pull request Jul 2, 2024
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 3, 2024
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 3, 2024
Signed-off-by: wayblink <anyang.wang@zilliz.com>
wayblink added a commit to wayblink/milvus that referenced this pull request Jul 3, 2024
Signed-off-by: wayblink <anyang.wang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Jul 3, 2024
…ism (#34384)

issue: #30633 
pr: #34194

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants