Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.4] format the sdk code #34699

Merged
merged 1 commit into from
Jul 16, 2024
Merged

enhance: [2.4] format the sdk code #34699

merged 1 commit into from
Jul 16, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Jul 16, 2024

@SimFG
enhance: [2.4] format the sdk code
8784610 
Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation area/test sig/testing labels Jul 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 16, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.95%. Comparing base (cf701a9) to head (8784610).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #34699       +/-   ##
===========================================
- Coverage   84.49%   69.95%   -14.54%     
===========================================
  Files         786     1050      +264     
  Lines      112573   135976    +23403     
===========================================
+ Hits        95116    95128       +12     
- Misses      13240    36630    +23390     
- Partials     4217     4218        +1

see 297 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Jul 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 13f129a into milvus-io:2.4 Jul 16, 2024
10 of 12 checks passed
@SimFG SimFG mentioned this pull request Jul 16, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jul 16, 2024
@SimFG
fix: [2.4] the lint-fix error (#34717)
9cf1f03 
- issue: #31293
- pr: #34033
- related pr: #34699

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@czs007 czs007

Labels
approved area/compilation area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimFG @czs007 @sre-ci-robot