Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] Expose indexing progress in DescribeIndex result #35066

Conversation

congqixia
Copy link
Contributor

See also #31293

See also milvus-io#31293

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/dependency Pull requests that update a dependency file labels Jul 29, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 29, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (3c7f731) to head (102bb6f).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35066      +/-   ##
==========================================
+ Coverage   81.01%   84.62%   +3.61%     
==========================================
  Files        1189      918     -271     
  Lines      143378   118726   -24652     
==========================================
- Hits       116153   100475   -15678     
+ Misses      22807    13831    -8976     
- Partials     4418     4420       +2     

see 294 files with indirect coverage changes

Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit cabb200 into milvus-io:master Jul 30, 2024
11 of 12 checks passed
OxalisCu pushed a commit to OxalisCu/milvus that referenced this pull request Jul 30, 2024
@congqixia congqixia deleted the enhance/expose_index_build_progress_descidx branch July 30, 2024 03:04
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
…lvus-io#35066)

See also milvus-io#31293

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants