Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: remove cooling off in rate limiter for read requests #35936

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #35934
pr: #35935

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Sep 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Sep 3, 2024
Signed-off-by: jaime <yun.zhang@zilliz.com>
@jaime0815 jaime0815 force-pushed the remove-read-cool-off-24 branch from 7dd4894 to 78089e6 Compare September 3, 2024 11:50
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (55df253) to head (78089e6).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35936      +/-   ##
==========================================
- Coverage   81.16%   81.13%   -0.04%     
==========================================
  Files        1056     1056              
  Lines      139414   139059     -355     
==========================================
- Hits       113161   112824     -337     
- Misses      21958    21959       +1     
+ Partials     4295     4276      -19     
Files with missing lines Coverage Δ
internal/proxy/impl.go 85.96% <ø> (-0.04%) ⬇️
internal/proxy/metrics_info.go 88.56% <ø> (-0.08%) ⬇️
internal/proxy/proxy.go 70.22% <ø> (-0.12%) ⬇️
internal/querynodev2/collector/collector.go 84.61% <ø> (-8.25%) ⬇️
internal/querynodev2/metrics_info.go 86.48% <ø> (+2.04%) ⬆️
internal/querynodev2/services.go 91.50% <ø> (+0.37%) ⬆️
internal/querynodev2/tasks/query_task.go 91.75% <ø> (-0.09%) ⬇️
internal/querynodev2/tasks/search_task.go 85.64% <ø> (-0.04%) ⬇️
internal/rootcoord/quota_center.go 86.49% <ø> (+0.98%) ⬆️
pkg/util/paramtable/quota_param.go 79.03% <ø> (-1.20%) ⬇️

... and 31 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 3, 2024
@bigsheeper
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Sep 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2c1fa50 into milvus-io:2.4 Sep 4, 2024
15 checks passed
@jaime0815 jaime0815 deleted the remove-read-cool-off-24 branch September 4, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants