Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix privilege group hasn't been register for validate #35938

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

weiliu1031
Copy link
Contributor

issue: #35471
pr: #35937

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Sep 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.93%. Comparing base (6158ad3) to head (7da9f21).
Report is 6 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.4   #35938   +/-   ##
=======================================
  Coverage   71.92%   71.93%           
=======================================
  Files        1057     1057           
  Lines      139105   139122   +17     
=======================================
+ Hits       100051   100075   +24     
- Misses      34779    34780    +1     
+ Partials     4275     4267    -8     
Files with missing lines Coverage Δ
internal/proxy/privilege_interceptor.go 85.06% <100.00%> (+1.03%) ⬆️
pkg/util/constant.go 100.00% <100.00%> (ø)
internal/rootcoord/root_coord.go 91.50% <0.00%> (ø)

... and 36 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Sep 3, 2024
@weiliu1031 weiliu1031 force-pushed the fix_privilege_group24 branch from 0180ba9 to 198dc76 Compare September 4, 2024 08:51
@mergify mergify bot removed the ci-passed label Sep 4, 2024
@weiliu1031 weiliu1031 force-pushed the fix_privilege_group24 branch from 198dc76 to 6875e04 Compare September 4, 2024 11:31
@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Sep 5, 2024
@SimFG
Copy link
Contributor

SimFG commented Sep 5, 2024

/lgtm

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@weiliu1031 weiliu1031 force-pushed the fix_privilege_group24 branch from 6875e04 to 7da9f21 Compare September 5, 2024 07:38
@sre-ci-robot sre-ci-robot removed the lgtm label Sep 5, 2024
@SimFG
Copy link
Contributor

SimFG commented Sep 5, 2024

/lgtm

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ceca666 into milvus-io:2.4 Sep 5, 2024
14 of 15 checks passed
weiliu1031 added a commit to weiliu1031/milvus that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants