-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [2.4] Fix tracing config update logic (#35928) #35998
Conversation
Related to milvus-io#35927 There are serveral issue this PR addresses: - Use `ResetTraceConfig` method instead init one in update event handler - Implement dynamic stats.Handler to receive tracing config update event - Update `enable_trace` flag when `ResetTraceConfig` is invoked - Change `enable_trace` to `std::atomic<bool>` in case of data race Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
@congqixia E2e jenkins job failed, comment |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #35998 +/- ##
==========================================
+ Coverage 71.92% 81.18% +9.25%
==========================================
Files 1057 1058 +1
Lines 139105 139153 +48
==========================================
+ Hits 100051 112965 +12914
+ Misses 34779 21907 -12872
- Partials 4275 4281 +6
|
/lgtm |
Cherry-pick from master
pr: #35928
Related to #35927
There are serveral issue this PR addresses:
ResetTraceConfig
method instead init one in update event handlerenable_trace
flag whenResetTraceConfig
is invokedenable_trace
tostd::atomic<bool>
in case of data race