Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix tracing config update logic (#35928) #35998

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35928
Related to #35927

There are serveral issue this PR addresses:

  • Use ResetTraceConfig method instead init one in update event handler
  • Implement dynamic stats.Handler to receive tracing config update event
  • Update enable_trace flag when ResetTraceConfig is invoked
  • Change enable_trace to std::atomic<bool> in case of data race

Related to milvus-io#35927

There are serveral issue this PR addresses:
- Use `ResetTraceConfig` method instead init one in update event handler
- Implement dynamic stats.Handler to receive tracing config update event
- Update `enable_trace` flag when `ResetTraceConfig` is invoked
- Change `enable_trace` to `std::atomic<bool>` in case of data race

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 5, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Sep 5, 2024
Copy link
Contributor

mergify bot commented Sep 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Sep 5, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 65.33333% with 26 lines in your changes missing coverage. Please review.

Project coverage is 81.18%. Comparing base (6158ad3) to head (0e71f35).
Report is 13 commits behind head on 2.4.

Files with missing lines Patch % Lines
pkg/tracer/stats_handler.go 62.29% 19 Missing and 4 partials ⚠️
internal/core/src/common/Tracer.cpp 81.81% 2 Missing ⚠️
internal/util/grpcclient/client.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35998      +/-   ##
==========================================
+ Coverage   71.92%   81.18%   +9.25%     
==========================================
  Files        1057     1058       +1     
  Lines      139105   139153      +48     
==========================================
+ Hits       100051   112965   +12914     
+ Misses      34779    21907   -12872     
- Partials     4275     4281       +6     
Files with missing lines Coverage Δ
internal/distributed/datacoord/service.go 88.73% <ø> (-0.11%) ⬇️
internal/distributed/datanode/service.go 82.12% <ø> (-0.18%) ⬇️
internal/distributed/indexnode/service.go 74.66% <ø> (-0.34%) ⬇️
internal/distributed/proxy/service.go 85.19% <100.00%> (-0.03%) ⬇️
internal/distributed/querycoord/service.go 77.72% <ø> (-0.20%) ⬇️
internal/distributed/querynode/service.go 83.14% <ø> (-0.19%) ⬇️
internal/distributed/rootcoord/service.go 82.67% <ø> (-0.14%) ⬇️
internal/util/grpcclient/client.go 86.37% <50.00%> (+1.71%) ⬆️
internal/core/src/common/Tracer.cpp 77.77% <81.81%> (+77.77%) ⬆️
pkg/tracer/stats_handler.go 62.29% <62.29%> (ø)

... and 241 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 5, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Sep 6, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 55b33cd into milvus-io:2.4 Sep 6, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/35928 branch September 6, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants