Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fill load field list from old version load info (#35993) #36018

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #35993
See also #35959

See also milvus-io#35959

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 5, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (9de4319) to head (675c2e0).
Report is 9 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querycoordv2/meta/collection_manager.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36018      +/-   ##
==========================================
+ Coverage   80.27%   85.01%   +4.73%     
==========================================
  Files        1057      790     -267     
  Lines      139246   114976   -24270     
==========================================
- Hits       111779    97745   -14034     
+ Misses      23199    12956   -10243     
- Partials     4268     4275       +7     
Files with missing lines Coverage Δ
internal/querycoordv2/meta/collection_manager.go 88.59% <91.30%> (+0.17%) ⬆️

... and 298 files with indirect coverage changes

@congqixia congqixia added this to the 2.4.11 milestone Sep 6, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit e21b09c into milvus-io:2.4 Sep 6, 2024
15 checks passed
@congqixia congqixia deleted the cp24/35993 branch September 6, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants