-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: metrics stored_index_files_size is never cleared #36161
fix: metrics stored_index_files_size is never cleared #36161
Conversation
Signed-off-by: jaime <yun.zhang@zilliz.com>
d05c9c0
to
62fb4c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #36161 +/- ##
=======================================
Coverage 81.15% 81.15%
=======================================
Files 1059 1059
Lines 139498 139499 +1
=======================================
+ Hits 113214 113215 +1
+ Misses 22007 22005 -2
- Partials 4277 4279 +2
|
/approve |
// GetCollectionIndexFilesSize returns the total index files size of all segment for each collection. | ||
func (m *meta) GetCollectionIndexFilesSize() uint64 { | ||
// SetStoredIndexFileSizeMetric returns the total index files size of all segment for each collection. | ||
func (m *meta) SetStoredIndexFileSizeMetric() uint64 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need to rename as SetXXX? since it returns a value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The primary function is to set values to metrics, so rename it from a 'get' to a 'set' method. The return value is intended solely for testing.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, jaime0815 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: ##36159
pr: #36160