Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force to set the metric type in the search request #36279

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Sep 14, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 14, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Sep 14, 2024
Copy link
Contributor

mergify bot commented Sep 14, 2024

@SimFG Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Sep 14, 2024
Copy link
Contributor

mergify bot commented Sep 14, 2024

@SimFG Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Signed-off-by: SimFG <bang.fu@zilliz.com>
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.90%. Comparing base (089790a) to head (33216ba).
Report is 18 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querynodev2/segments/collection.go 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36279      +/-   ##
==========================================
- Coverage   71.91%   71.90%   -0.02%     
==========================================
  Files        1059     1060       +1     
  Lines      139495   139599     +104     
==========================================
+ Hits       100322   100377      +55     
- Misses      34892    34944      +52     
+ Partials     4281     4278       -3     
Files with missing lines Coverage Δ
internal/querycoordv2/task/executor.go 80.90% <100.00%> (-0.34%) ⬇️
internal/querynodev2/services.go 91.72% <100.00%> (-0.29%) ⬇️
internal/querynodev2/segments/collection.go 89.10% <68.42%> (-2.87%) ⬇️

... and 33 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Sep 18, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Sep 18, 2024

/run-cpu-e2e

1 similar comment
@czs007
Copy link
Collaborator

czs007 commented Sep 18, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Sep 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Sep 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 95e47bf into milvus-io:2.4 Sep 18, 2024
13 of 15 checks passed
@yanliang567 yanliang567 added this to the 2.4.12 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants