Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Return all compactTo segments after support split (#36361) #36429

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Sep 23, 2024

Cherry-pick from master
pr: #36361
Related to #36360

Related to milvus-io#36360

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. approved labels Sep 23, 2024
Copy link
Contributor

mergify bot commented Sep 23, 2024

@congqixia Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.84%. Comparing base (7ac3ef9) to head (171b769).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/segment_info.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36429      +/-   ##
==========================================
- Coverage   71.88%   71.84%   -0.05%     
==========================================
  Files        1060     1060              
  Lines      139734   139739       +5     
==========================================
- Hits       100452   100396      -56     
- Misses      34999    35041      +42     
- Partials     4283     4302      +19     
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.95% <100.00%> (ø)
internal/datacoord/services.go 85.08% <100.00%> (ø)
internal/datacoord/segment_info.go 84.68% <75.00%> (-0.54%) ⬇️

... and 29 files with indirect coverage changes

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e083bf3 into milvus-io:2.4 Sep 23, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/36361 branch September 24, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants