Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cherry-pick]Fix data race for cluerting compaction #36499

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36438

master pr: #36440

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Sep 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.97%. Comparing base (bdc59f3) to head (f17b37b).
Report is 10 commits behind head on 2.4.

Files with missing lines Patch % Lines
...ternal/datanode/compaction/clustering_compactor.go 57.14% 8 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36499      +/-   ##
==========================================
- Coverage   84.97%   84.97%   -0.01%     
==========================================
  Files         793      793              
  Lines      115327   115328       +1     
==========================================
- Hits        98003    98000       -3     
- Misses      13035    13040       +5     
+ Partials     4289     4288       -1     
Files with missing lines Coverage Δ
...ternal/datanode/compaction/clustering_compactor.go 67.75% <57.14%> (+0.04%) ⬆️

... and 23 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Sep 28, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 132e4c3 into milvus-io:2.4 Sep 28, 2024
14 of 15 checks passed
@xiaocai2333 xiaocai2333 deleted the fix_clustering_data_race-2 branch November 8, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants