Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use common gc config (#36668) #36670

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

bigsheeper
Copy link
Contributor

Use the GC config from common and remove the GC config from queryNode.

issue: #36667

pr: #36668

related pr: #34949

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 8, 2024
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@mergify mergify bot added the ci-passed label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.52%. Comparing base (da2d3fb) to head (29dfe6c).
Report is 13 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #36670       +/-   ##
===========================================
- Coverage   81.20%   68.52%   -12.68%     
===========================================
  Files        1064     1056        -8     
  Lines      140454   139453     -1001     
===========================================
- Hits       114054    95563    -18491     
- Misses      22072    39537    +17465     
- Partials     4328     4353       +25     
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.34% <100.00%> (-0.01%) ⬇️

... and 426 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Oct 9, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9cb5396 into milvus-io:2.4 Oct 9, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants