Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] Add balance report log for qc balancer #36749

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

congqixia
Copy link
Contributor

Cherry pick from master
pr: #36747
Related to #36746

Related to milvus-io#36746

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia added this to the 2.4.13 milestone Oct 10, 2024
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 10, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 10, 2024
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@mergify mergify bot added the ci-passed label Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 90.55118% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.96%. Comparing base (c69af44) to head (5d2e976).
Report is 2 commits behind head on 2.4.

Files with missing lines Patch % Lines
...ernal/querycoordv2/balance/multi_target_balance.go 0.00% 10 Missing ⚠️
internal/querycoordv2/balance/report.go 97.43% 1 Missing ⚠️
...ernal/querycoordv2/balance/score_based_balancer.go 97.95% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36749      +/-   ##
==========================================
+ Coverage   71.95%   71.96%   +0.01%     
==========================================
  Files        1064     1065       +1     
  Lines      140580   140673      +93     
==========================================
+ Hits       101159   101241      +82     
- Misses      35093    35095       +2     
- Partials     4328     4337       +9     
Files with missing lines Coverage Δ
internal/querycoordv2/balance/balance.go 94.20% <100.00%> (ø)
...erycoordv2/balance/channel_level_score_balancer.go 95.17% <100.00%> (+0.24%) ⬆️
...al/querycoordv2/balance/rowcount_based_balancer.go 95.27% <100.00%> (+0.16%) ⬆️
internal/querycoordv2/balance/utils.go 48.00% <100.00%> (ø)
internal/querycoordv2/balance/report.go 97.43% <97.43%> (ø)
...ernal/querycoordv2/balance/score_based_balancer.go 97.39% <97.95%> (-0.09%) ⬇️
...ernal/querycoordv2/balance/multi_target_balance.go 83.89% <0.00%> (-1.83%) ⬇️

... and 30 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit b24788b into milvus-io:2.4 Oct 11, 2024
14 of 15 checks passed
@congqixia congqixia deleted the cp24/36747 branch October 15, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants