fix: Delegator may becomes unserviceable after querycoord restart #37055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after querycoord restart, segment_checker may release segment by mistake due to next target isn't ready yet. This PR requires release segment must happens after next target is ready. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
mergify
bot
added
dco-passed
congqixia
reviewed
Oct 23, 2024
| @@ -192,13 +192,14 @@ func (c *SegmentChecker) getGrowingSegmentDiff(collectionID int64, | |||
| continue | |||
| } | |||
|
|
|||
| nextTargetExist := c.targetMgr.IsNextTargetExist(collectionID) | |||
There was a problem hiding this comment.
- why don't we just skip this round if nextTarget not Exist?
- targetVersion := c.targetMgr.GetCollectionTargetVersion(collectionID, meta.CurrentTarget)
if view.TargetVersion != targetVersion {
// before shard delegator update it's readable version, skip release segment
log.RatedInfo(20, "before shard delegator update it's readable version, skip release segment",
zap.String("channelName", channelName),
zap.Int64("nodeID", node),
zap.Int64("leaderVersion", view.TargetVersion),
zap.Int64("currentVersion", targetVersion),
)
continue
}
can we handle by this logic above but not introduce another nextTargetExist check?
the code itself is very redundant
There was a problem hiding this comment.
- we can't use same condition to skip this round, cause load segment just require next target exist, but release segment require both current target and next target exists.
- target version can't block releasing segment in next target, cause it only works for current target
target_observer will update current target first, then update next target. so current target and next target will both survive even if they have same content. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: weiliu1031, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
weiliu1031
added a commit
to weiliu1031/milvus
that referenced
this pull request
Oct 24, 2024
…lvus-io#37055) issue: milvus-io#37054 after querycoord restart, segment_checker may release segment by mistake due to next target isn't ready yet. This PR requires release segment must happens after next target is ready. Signed-off-by: Wei Liu <wei.liu@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #37054
after querycoord restart, segment_checker may release segment by mistake due to next target isn't ready yet.
This PR requires release segment must happens after next target is ready.