Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] allow to delete data when disk quota exhausted #37139

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Signed-off-by: SimFG <bang.fu@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 25, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 25, 2024
@sre-ci-robot sre-ci-robot merged commit ae4ce9b into milvus-io:2.4 Oct 25, 2024
13 checks passed
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.55%. Comparing base (6bc8aba) to head (7fc278f).
Report is 5 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37139      +/-   ##
==========================================
- Coverage   80.56%   80.55%   -0.02%     
==========================================
  Files        1066     1066              
  Lines      165211   165241      +30     
==========================================
- Hits       133110   133108       -2     
- Misses      27763    27783      +20     
- Partials     4338     4350      +12     
Files with missing lines Coverage Δ
internal/rootcoord/quota_center.go 82.86% <100.00%> (-0.43%) ⬇️
pkg/util/typeutil/set.go 96.87% <100.00%> (+4.40%) ⬆️

... and 35 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants