Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [cp24]Saperate L0 and Mix trigger interval #37319

Merged
merged 5 commits into from
Nov 6, 2024
Merged

fix: [cp24]Saperate L0 and Mix trigger interval #37319

merged 5 commits into from
Nov 6, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #37108
pr: #37190

  • Add MixCompactionTriggerInterval, default 60s
  • Add L0CompactionTriggerInterval, default 10s
  • Export Single related compaction configs
  • Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/test sig/testing test/integration integration test labels Oct 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 31, 2024
@XuanYang-cn XuanYang-cn changed the title fix: Saperate L0 and Mix trigger interval fix: [cp24]Saperate L0 and Mix trigger interval Oct 31, 2024
@XuanYang-cn XuanYang-cn added this to the 2.4.15 milestone Oct 31, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 31, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

rerun go-sdk

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
fix: Saperate L0 and Mix trigger interval
f023274 
See also: milvus-io#37108
pr: milvus-io#37190

- Add MixCompactionTriggerInterval, default 60s
- Add L0CompactionTriggerInterval, default 10s
- Export Single related compaction configs
- Raise SingleCompactionDeltaLogMaxSize from 2MB to 16MB

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 1, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (37d691f) to head (d2cbefa).
Report is 16 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37319      +/-   ##
==========================================
+ Coverage   79.05%   80.57%   +1.52%     
==========================================
  Files        1061     1069       +8     
  Lines      164564   165693    +1129     
==========================================
+ Hits       130088   133512    +3424     
+ Misses      30108    27815    -2293     
+ Partials     4368     4366       -2
Files with missing lines Coverage Δ
internal/datacoord/compaction_trigger.go 85.09% <100.00%> (+2.15%) ⬆️
internal/datacoord/compaction_trigger_v2.go 72.10% <100.00%> (+36.59%) ⬆️
pkg/util/paramtable/component_param.go 98.35% <100.00%> (+0.01%) ⬆️

... and 187 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 4, 2024
tedxu
tedxu reviewed Nov 4, 2024
View reviewed changes
pkg/util/paramtable/component_param.go Outdated Show resolved Hide resolved
pkg/util/paramtable/component_param.go Outdated Show resolved Hide resolved
internal/datacoord/compaction_trigger.go Show resolved Hide resolved
@XuanYang-cn
enhance according to the comment
e3d4ab7 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 4, 2024
@mergify mergify bot removed the ci-passed label Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 5, 2024
@tedxu
Copy link
Contributor

tedxu commented Nov 6, 2024

/lgtm

congqixia
congqixia approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 20534a3 into milvus-io:2.4 Nov 6, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/ease-ds branch November 6, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedxu tedxu tedxu left review comments

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@tedxu tedxu

@congqixia congqixia

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
2.4.15
Development

Successfully merging this pull request may close these issues.
4 participants
@XuanYang-cn @tedxu @sre-ci-robot @congqixia