Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4]Update the template expression proto to improve transmission efficiency #37485

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #36672

master pr: #37484

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/XL Denotes a PR that changes 500-999 lines. labels Nov 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 6, 2024
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333 xiaocai2333 force-pushed the update_expression_proto-4 branch from 09484d5 to 96888b0 Compare November 7, 2024 02:12
@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Nov 7, 2024
@sre-ci-robot sre-ci-robot merged commit 651a56e into milvus-io:2.4 Nov 7, 2024
13 checks passed
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 76.28866% with 23 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (20534a3) to head (96888b0).
Report is 4 commits behind head on 2.4.

Files with missing lines Patch % Lines
...lanparserv2/convert_field_data_to_generic_value.go 76.28% 19 Missing and 4 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37485      +/-   ##
==========================================
- Coverage   80.58%   79.62%   -0.96%     
==========================================
  Files        1069     1069              
  Lines      165656   165730      +74     
==========================================
- Hits       133486   131956    -1530     
- Misses      27808    29402    +1594     
- Partials     4362     4372      +10     
Files with missing lines Coverage Δ
...lanparserv2/convert_field_data_to_generic_value.go 78.78% <76.28%> (-2.25%) ⬇️

... and 96 files with indirect coverage changes

@xiaocai2333 xiaocai2333 deleted the update_expression_proto-4 branch November 8, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants