Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4]Fix the bug that retrieved from wrong field for L0 segments #37599

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #37574

master pr: #37598

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 12, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 12, 2024

/approve
/lgtm

Copy link
Contributor

mergify bot commented Nov 12, 2024

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed lgtm size/XS Denotes a PR that changes 0-9 lines. labels Nov 12, 2024
@mergify mergify bot added the ci-passed label Nov 12, 2024
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.22%. Comparing base (25c9699) to head (51da760).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37599      +/-   ##
==========================================
- Coverage   79.65%   72.22%   -7.44%     
==========================================
  Files        1069     1069              
  Lines      166729   166729              
==========================================
- Hits       132816   120414   -12402     
- Misses      29507    41900   +12393     
- Partials     4406     4415       +9     
Files with missing lines Coverage Δ
internal/querynodev2/handlers.go 77.58% <100.00%> (-0.51%) ⬇️

... and 248 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Nov 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3456e24 into milvus-io:2.4 Nov 12, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants