Enable faster sync #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
added
core
|
Moved from draft and into review. |
2 tasks
|
How very ironic. I offered this exact design many months ago in mimblewimble/grin#2837 - and yet it was you who sent me a long cutting message in gitter for a mere mention of adding a UTXO commitment. I'm elated to see progress finally being made - tho I do wish I wasn't promptly shooed away. We may have been 6 months closer to seeing these changes in action... |
|
@cadmuspeverell Good to see you around again. I wouldn't call it ironic necessarily - more that we took the time to think it through fully (both #2837 and other similar proposals). |
DavidBurkett
approved these changes
Dec 2, 2019
text/0000-enable-faster-sync.md
Outdated
| - Authors: [Antioch Peverell](mailto:apeverell@protonmail.com), [John Tromp](mailto:john.tromp@gmail.com) | ||
| - Start date: Oct 25, 2019 | ||
| - RFC PR: Edit if merged: [mimblewimble/grin-rfcs#0000](https://github.com/mimblewimble/grin-rfcs/pull/0000) | ||
| - Tracking issue: [Edit if merged with link to tracking github issue] |
There was a problem hiding this comment.
Please update this to point to: mimblewimble/grin#3173
text/0000-enable-faster-sync.md
Outdated
| - Title: enable-faster-sync | ||
| - Authors: [Antioch Peverell](mailto:apeverell@protonmail.com), [John Tromp](mailto:john.tromp@gmail.com) | ||
| - Start date: Oct 25, 2019 | ||
| - RFC PR: Edit if merged: [mimblewimble/grin-rfcs#0000](https://github.com/mimblewimble/grin-rfcs/pull/0000) |
There was a problem hiding this comment.
This will be RFC 0009
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC proposal for enabling faster sync via "batched" subtrees of the output PMMR.
We have a way forward to verify subtrees of the output PMMR without necessarily having to wait to download the full output and kernel PMMRs. This lets us download subtrees of the output PMMR from multiple peers in parallel, verifying them as they arrive.
Plan is to eventually remove the existing bottleneck around the sync process where we are currently limited to waiting for a single monolithic
txhashset.zipdownload from a single, potentially slow or unreliable peer.Splitting this download across multiple peers and allowing these to happen in parallel will allow the whole sync process to be faster and more robust.