-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Team #39
Security Team #39
Conversation
@j01tz it was brought to my attention that as both security team and core team are intermixed in the document, Also following gov meeting just now, would be great if you could drop "sub-team" for just "team" instead in the doc. :) |
Following your comment, I'm debating language use in veto section
or
The former gives the team the ability to broadly veto any impactful security-related decision (though doesn't guarantee its awareness of these situations). The latter restricts it to "security team decisions" which would be narrowly interpreted as what is specified in the RFC document and what is explicitly delegated by core. Depending on the approach we could do a better job in the RFC of spelling out what are explicitly security team decisions if we don't want to leave "security-related decisions" up to interpretation. |
I’d be inclined to go with the latter: security team decision Practically speaking, the remits of the security team is contained within the security team itself. It cannot get veto powers on matters that are not handled by the team. |
Thanks very much for the feedback.
|
Looks good @j01tz, bar any objections from others I'm going to recommend that this RFC moves into Final Comment Period with a disposition to merge tomorrow during the governance meeting. 👍 |
Following discussion in today's Governance meeting, and in line with our governance process, this RFC can be considered being in Final Comment Period from today, with a disposition to merge in two weeks time, on February 25. Please ensure any comments are made before then! ⏳ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took quite a detailed pass @j01tz, let me know what you think 👍
Thanks for the feedback @lehnberg. I think I was able to address your comments. I also added a line for clarification in the decision making section. |
Looks good to go as is, thanks @j01tz for putting all of this together. |
Following discussion in yesterday's Governance meeting, and in line with our governance process, following two weeks of final comment period, this RFC can now be considered Accepted. 🎉 |
Rendered link to RFC document
This is a proposal to create a security team for Grin.