Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commitments are 33 bytes, not 32 bytes #51

Merged
merged 1 commit into from
Apr 20, 2020
Merged

commitments are 33 bytes, not 32 bytes #51

merged 1 commit into from
Apr 20, 2020

Conversation

antiochp
Copy link
Member

@antiochp antiochp commented Apr 20, 2020 •
edited by quentinlesceller
Loading

Fix commitment size (33 bytes, not 32 bytes) in the "variable size kernels" RFC.
Also reference the revised nrd-kernels RFC (was relative-kernels).

@antiochp
commitments are 33 bytes, not 32 bytes
41d45a8 
reference to proposed nrd-kernels RFC
quentinlesceller
quentinlesceller approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@quentinlesceller quentinlesceller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed nice catch 👍

@antiochp antiochp merged commit 2e32e05 into mimblewimble:master Apr 20, 2020
@antiochp antiochp deleted the 33_bytes branch April 20, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quentinlesceller quentinlesceller quentinlesceller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antiochp @quentinlesceller