Fix past fees #77
Merged
Fix past fees #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBurkett
approved these changes
Mar 23, 2021
|
@tromp Have you confirmed nobody has used a fee that large in the past? If you have, then I see no reason we can't get this accepted. |
phyro
reviewed
Apr 4, 2021
text/0000-fix-prior-fees.md
Outdated
| [community-level-explanation]: #community-level-explanation | ||
|
|
||
| The largest fee to appear on mainnet prior to Hark Fork 4 is 2.404 Grin. This means that extending the current 40-bit fee restriction to the pre-HF4 history preserves validity. | ||
| While this is technically a hard-forking change, it would only have any visible |
There was a problem hiding this comment.
this sentence "it would only have any visible" is unfinished
|
Should we move it to FCP and get it accepted ASAP so that we can also tackle the PR that implements this? |
|
In line with our governance process, this RFC can be considered being in Final Comment Period, with a disposition to merge in two weeks time, on April 20. Please ensure any comments are made before then! |
quentinlesceller
approved these changes
Apr 7, 2021
text/0000-fix-prior-fees.md
Outdated
| [summary]: #summary | ||
|
|
||
| Carry the restriction of fees, to 40 bits since HF4, back to all history. | ||
| Do not change headerversion despite the hard-forking nature. |
There was a problem hiding this comment.
Suggested change
| Do not change headerversion despite the hard-forking nature. | |
| Do not change `headerversion` despite the hard-forking nature. |
or
Suggested change
| Do not change headerversion despite the hard-forking nature. | |
| Do not change header version despite the hard-forking nature. |
text/0000-fix-prior-fees.md
Outdated
| ## Motivation | ||
| [motivation]: #motivation | ||
|
|
||
| This makes the FeeFields methods fee() and fee\_shift() height independent, |
There was a problem hiding this comment.
Suggested change
| This makes the FeeFields methods fee() and fee\_shift() height independent, | |
| This makes the `FeeFields` methods `fee()` and `fee_shift()` height independent, |
text/0000-fix-prior-fees.md
Outdated
| ## References | ||
| [references]: #references | ||
|
|
||
| [1] [Grin github](https://github.com/mimblewimble/grin/blob/acba73bf40242f963d8ea1e7128dfdfde6fb8853/core/src/core/transaction.rs#L181-L188) |
There was a problem hiding this comment.
Maybe a different link name?
j01tz
approved these changes
Apr 20, 2021
text/0000-fix-prior-fees.md
Outdated
| This makes the `FeeFields` methods `fee()` and `fee\_shift()` height independent, | ||
| as well as several other functions which end up calling them. | ||
| This results in nontrivial code and consensus model simplification, | ||
| with no downsise, which is always a good thing. |
text/0000-fix-prior-fees.md
Outdated
| ## Motivation | ||
| [motivation]: #motivation | ||
|
|
||
| This makes the `FeeFields` methods `fee()` and `fee\_shift()` height independent, |
There was a problem hiding this comment.
Should fee\_shift() -> fee_shift()?
2 tasks
update README
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to rendered text
Implemented in PRs mimblewimble/grin#3629 and mimblewimble/grin-wallet#602 .