Update transactions via kernel where necessary #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeastplume
changed the title
|
Is this PR ready for review? |
|
Yes, please by all means |
jaspervdm
reviewed
Sep 22, 2019
jaspervdm
approved these changes
Sep 23, 2019
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
* add test for no change output scenario * rustfmt * add kernel lookup functionality to transaction retrievals * rustfmt * updates and fixes for no-change invoice workflow, test implementations * rustfmt
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* add test for no change output scenario * rustfmt * add kernel lookup functionality to transaction retrievals * rustfmt * updates and fixes for no-change invoice workflow, test implementations * rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of kernel lookups, current thinking is to keep the current output-based assumptions in place, track cases where a sender has no change outputs and only perform kernel-lookups to see whether a transaction has been confirmed in that instance.
Still more testing, edge cases and test implementations required, but what's there at the moment seems to work (see the
no_changetest incontroller\tests