Store and use last scanned PMMR height in check_repair
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeastplume
changed the title
check_repair
|
This is in a working state, so would like to merge work on this to date shortly as part of works for https://github.com/yeastplume/grin-rfcs/blob/master/text/0000-wallet-update-process.md. In the current state, the incremental scanning by block height is complete and working. Would like to avoid a single mega-PR for this work, so subsequent PRs will fill in some of the details details according to how the RFC develops. |
yeastplume
changed the title
check_repaircheck_repair
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
…e#246) * store last scanned PMMR check index * rustfmt * fix issue where account names will be overwritten on check_repair * rustfmt * attempts to include check_repair scan as part of normal update * rustfmt * fix error on restore due to incorrect parent key id being set * addition of calls to heigt_range_to_pmmr_indices traits and implementations * rustfmt * get_chain_height -> get_chain_tip * rustfmt * retrieve height+hash from node, modify check_repair to use block heights * rustfmt * fixes from live testing * rustfmt * test cleanup and change dependencies back to grin master * rustfmt
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
…e#246) * store last scanned PMMR check index * rustfmt * fix issue where account names will be overwritten on check_repair * rustfmt * attempts to include check_repair scan as part of normal update * rustfmt * fix error on restore due to incorrect parent key id being set * addition of calls to heigt_range_to_pmmr_indices traits and implementations * rustfmt * get_chain_height -> get_chain_tip * rustfmt * retrieve height+hash from node, modify check_repair to use block heights * rustfmt * fixes from live testing * rustfmt * test cleanup and change dependencies back to grin master * rustfmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #244, it will be necessary to store the last scanned height during a
check_repair, and part of the wallet update process should be to 'check_repair` back a threshold of blocks from the last scanned height. This PR aims to add that functionality, as well as modifying the existing check_repair method to accept a number of block heights back to start scanning from.May require some changes or an addition to the node API to support this properly, still exploring what the best thing to do is here.